Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tests #13

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Simplify tests #13

merged 5 commits into from
Mar 27, 2024

Conversation

radarhere
Copy link

Suggestions for python-pillow#7209

  • Move sample bytes inside test. I expect you had it outside the test so that it could be reused, but I don't think we value speed quite that highly in the test suite
  • Simplified the code by using assert_image_equal() instead of asserting the results of getpixel()
  • The number of bands is no longer used, so I've removed them.
  • Added type hints for the return values of the tests
  • Only specify the image size once in a test. This is fairly minor, but it feels neater

@Yay295 Yay295 merged commit a4aac18 into Yay295:bytes_tests Mar 27, 2024
48 of 50 checks passed
@radarhere radarhere deleted the bytes_tests branch March 27, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants